From: Jon Maloy <jon.ma...@ericsson.com>
Date: Thu, 12 Oct 2017 16:02:22 +0200

> @@ -288,6 +289,7 @@ static int tipc_receive_from_sock(struct tipc_conn *con)
>  }
>  
>  static int tipc_accept_from_sock(struct tipc_conn *con)
> +
>  {

This whitespace change seems unintentional.

> +bool tipc_topsrv_kern_subscr(struct net *net, u32 port, u32 type,
> +                          u32 lower, u32 upper, int *conid)
> +{
> +     struct tipc_server *s;
> +     struct tipc_conn *con;
> +     struct tipc_subscriber *scbr;
> +     struct tipc_subscr sub;

Please order local variables from longest to shortest line.

>  static void tipc_send_to_sock(struct tipc_conn *con)
>  {
>       int count = 0;
>       struct tipc_server *s = con->server;
> +     struct tipc_event *evt;
>       struct outqueue_entry *e;
>       struct msghdr msg;
>       int ret;

Likewise.

Reply via email to