Hi all, It is perfectly possible for the following to happen:
# ls /sys/class/net/gphy/queues rx-0 tx-0 tx-1 tx-2 tx-3 # tc qdisc add dev gphy root handle 1: multiq # tc filter add dev gphy parent 1: protocol ip prio 1 u32 match ip dst 192.168.1.1 action skbedit queue_mapping 5 that specifies a queue_mapping value that exceeds what the underlying device supports. There is a check for dev->real_num_tx_queue > d->queue_mapping in tcf_skbedit() which makes sure we won't overflow the queue space, but this will essentially render the action inactive. I can't find a way to get a reference on a network device from a tc_action_ops->init function in order to validate that the queue_mapping is valid at ->init() time and return an appropriate error if we are exceeding what the device does. This is an action chained to a match and a filter, so somehow one would think it would be possible to obtain a reference on the network device the filter was installed on... Any clues how we could fix that? -- Florian
