On 10/11/17 7:54 AM, Ido Schimmel wrote: >> @@ -4533,7 +4541,9 @@ static int __init mlxsw_sp_module_init(void) >> int err; >> >> register_netdevice_notifier(&mlxsw_sp_netdevice_nb); >> + register_inetaddr_validator_notifier(&mlxsw_sp_inetaddr_valid_nb); >> register_inetaddr_notifier(&mlxsw_sp_inetaddr_nb); >> + register_inet6addr_validator_notifier(&mlxsw_sp_inet6addr_valid_nb); >> register_inet6addr_notifier(&mlxsw_sp_inet6addr_nb); >> register_netevent_notifier(&mlxsw_sp_router_netevent_nb); > Need unregister in rollback and __exit function. >
oops, thanks for noticing that. Fixed and took care of your other comments.