Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

[Vivien Didelot]

Hi Brandon,

Vivien Didelot <vivien.dide...@savoirfairelinux.com> writes:

> Brandon Streiff <brandon.stre...@ni.com> writes:
>
>> +    .port_ptp_read          = mv88e6352_port_ptp_read,
>> +    .port_ptp_write         = mv88e6352_port_ptp_write,
>> +    .ptp_read               = mv88e6352_ptp_read,
>> +    .ptp_write              = mv88e6352_ptp_write,
>> +    .tai_read               = mv88e6352_tai_read,
>> +    .tai_write              = mv88e6352_tai_write,
>
>> +    .port_ptp_read          = mv88e6390_port_ptp_read,
>> +    .port_ptp_write         = mv88e6390_port_ptp_write,
>> +    .ptp_read               = mv88e6390_ptp_read,
>> +    .ptp_write              = mv88e6390_ptp_write,
>> +    .tai_read               = mv88e6390_tai_read,
>> +    .tai_write              = mv88e6390_tai_write,
>
> Only nitpick: please keep the mv88e63{52,90}_g2_avb_ prefix here.
>
> Otherwise thanks for respecting the code organization, very clear patch:
>
> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com>

Also feel free to move the mv88e6*_g2_avb_ functions into a
global2_avb.c file.

Thank you,

      Vivien