Re: [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

[Stephen Hemminger]

On Tue,  3 Oct 2017 11:21:14 -0700
Roopa Prabhu <ro...@cumulusnetworks.com> wrote:

> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
> index 48fb174..7a50dc5 100644
> --- a/net/bridge/br_forward.c
> +++ b/net/bridge/br_forward.c
> @@ -204,7 +204,8 @@ void br_flood(struct net_bridge *br, struct sk_buff *skb,
>               /* Do not flood to ports that enable proxy ARP */
>               if (p->flags & BR_PROXYARP)
>                       continue;
> -             if ((p->flags & BR_PROXYARP_WIFI) &&
> +             if ((p->flags & BR_PROXYARP_WIFI ||
> +                  p->flags & BR_NEIGH_SUPPRESS) &&
>                   BR_INPUT_SKB_CB(skb)->proxyarp_replied)
>                       continue;

Don;t you need additional paren here to avoid warnings.
Or do one mask:
                if ((p->flags & (BR_PROXYARP_WIFI | BR_NEIGH_SUPPRESS)) &&
                    BR_INPUT_SKB_CB(skb)->proxyarp_replied)
                        continue;