On Monday 14 August 2006 20:55, John W. Linville wrote: > On Wed, Aug 09, 2006 at 04:13:25PM -0500, Larry Finger wrote: > > This patch removes the ugly TODO output from the logs for bcm43xx-softmac. > > The > > patch is for the latest version of Linville's wireless-2.6 tree. > > I'm not sure if this is the right approach. In fact I know it isn't -- > the right approach would be to implement the missing code! :-) > > But barring that, wouldn't it be better to change the TODO() macro > to key off a build-time definition like CONFIG_BCM43XX_DEBUG? > > Michael, what do you think?
Heh, well. Actually the TODO define should have died since months. BUT: There are still 11 uses of it and they are _all_ valid uses. _None_ of these should be removed without implementing the code at the same time. So, well. What about compiling it to a no-op if BCM43XX_DEBUG is not defined. I think this is a bad idea. These TODOs are there for a _very_ good reason. They say: "If you see this in dmesg, feature foobar does not work at all". They are a very good hint to the user (and escpecially to the developers when dealing with "bugreports"). So: If someone would like that a TODO disappears in the logs, go forward and implement the code. (Actually, most TODOs are there because of incomplete specifications. But that might have changed inbetween). -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
