On Mon, Aug 14, 2006 at 10:15:14AM +0200, Johannes Berg wrote: > Somewhere, sometime, someone had to start getting rid of bitfields ;)
Yes and you wouldn't believe how many times I have had to complain about this particular case internally with it always coming back as bitfield even after showing that it caused a unaligned access on one target platform.. However, I remember fixing this long time ago to use proper operation on u8 values. It looks like I just have forgotten to submit those changes to wireless-dev.git. There was quite a bit of additional cleanup, so it would probably be best if I were to take a closer look at propose an alternative patch for changing this and getting rid for struct qos_control. > + u16 *p = (u16 *) (skb->data + ieee80211_get_hdrlen(fc) - 2); > + u16 qos_hdr = skb->priority & QOS_CONTROL_TAG1D_MASK; > if (local->wifi_wme_noack_test) > - qc->ack_policy = 1; > + qos_hdr |= QOS_CONTROL_ACK_POLICY_NOACK << > + QOS_CONTROL_ACK_POLICY_SHIFT; > + *p = cpu_to_le16(qos_hdr); I think that this is always 16-bit aligned in the current implementation, but I would be a bit careful with this type of change here. This can be done easily with u8 since the qos_control field has 8 bits of used data and 8 bits of reserved field. My change was handling this as two separate 8-bit values, so no issues with potential unaligned accesses. -- Jouni Malinen PGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
