On 9/27/17 10:51 PM, David Miller wrote: > From: David Ahern <dsah...@gmail.com> > Date: Wed, 27 Sep 2017 19:08:00 -0700 > >> fib_weight in fib_info is set but not used. Remove it and the >> helpers for setting it. >> >> Signed-off-by: David Ahern <dsah...@gmail.com> > > Hmmm, I wonder then what Peter intended in commit > 0e884c78ee19e902f300ed147083c28a0c6302f0 ("ipv4: L3 hash-based > multipath") because that's where this came from. >
You can see that fib_weight is set but not used in his patch either. Perhaps it was an early idea that was replaced by the per-nexthop nh_upper_bound and that code was not removed.