On 09/27/2017 12:19 PM, Vivien Didelot wrote: > Hi Andrew, Florian, > > Andrew Lunn <[email protected]> writes: > >> It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING >> enabled. Any change to enable hardware flooding needs careful testing >> for lots of different configurations. This is another reason i don't >> want to do it at the DSA level, until we have a good understanding >> what it means in each individual driver. > > Then if we are worried about how broadcast flooding is handled on > different switches, we can provide a new .flood_broadcast(ds, vid) > switch operation for the drivers to implement.
We don't really have a good visibility on the number of switches requiring special configuration for broadcast addresses nor how this would have to happen so it would be a tad difficult to define an appropriate API with a single user. In general, single user "generic" facilities tend to be biased towards their particular problem space (c.f: devlink) so a generic interface to call into HW specific details does not usually sell well... -- Florian
