From: "Michal Ruzicka" <[EMAIL PROTECTED]>
Date: Fri, 11 Aug 2006 12:04:53 +0100

> You are absolutely right, I just failed to notice that -ENODEV return value
> from ip_mc_del_src()/ip_mc_leave_src() is ignored.
> Here comes the patch:
 ...
> >         Also, ip_mc_leave_group() has the same issue; looks
> > like it just needs the "if (in_dev)" removed before the call to
> > ip_mc_leave_src().
> 
> In fact it is a slightly different issue, there is no leak in this
> function. Rather the function completely fails to leave a multicast
> group joined on an interface that does not exist any more.
 ...
> Here comes a patch for that:

Both of these fixes look fine to me.  David?

(Meanwhile, Michal, can I get a Signed-off-by: line from you for these
 patches?  Thanks a lot.)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to