David Ahern <dsah...@gmail.com> wrote: > On 9/21/17 10:59 AM, Florian Westphal wrote: > > @@ -539,6 +543,8 @@ static int rtnl_link_slave_info_fill(struct sk_buff > > *skb, > > struct nlattr *slave_data; > > int err; > > > > + ASSERT_RTNL(); > > + [..] master_dev = netdev_master_upper_dev_get((struct net_device *) dev);
> Since rtnl_link_slave_info_fill and rtnl_link_info_fill are only called > by rtnl_link_fill and rtnl_link_fill is only called rtnl_fill_ifinfo > which as the ASSERT_RTNL why add to these lower functions as well? I'll remove this patch in v2 and will hold it back in my private queue; these serve more as a reminder/TODO for myself rather than anything else.
