On 06-08-13 11:24 Michael Buesch wrote:
> On Saturday 12 August 2006 19:00, Daniel Drake wrote:
> > --- linux-2.6.orig/drivers/net/wireless/zd1211rw/zd_mac.c
> > +++ linux-2.6/drivers/net/wireless/zd1211rw/zd_mac.c
> > @@ -127,11 +127,9 @@ out:
> >
> > void zd_mac_clear(struct zd_mac *mac)
> > {
> > - /* Aquire the lock. */
> > - spin_lock(&mac->lock);
> > - spin_unlock(&mac->lock);
> > zd_chip_clear(&mac->chip);
> > - memset(mac, 0, sizeof(*mac));
> > + ZD_ASSERT(!spin_is_locked(&mac->lock));
>
> I think this assertion will always trigger on UP kernels
> with spinlock debugging disabled.
On UP the spin lock will be never locked, so the assert can never
fail. It's tested.
--
Uli Kunitz
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
