Hi, On Tue, 2017-09-19 at 05:00 -0700, Eric Dumazet wrote: > On Tue, 2017-09-19 at 12:46 +0200, Paolo Abeni wrote: > .. > > > Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> > > Signed-off-by: Paolo Abeni <pab...@redhat.com> > > --- > > +/* called under RCU lock */ > > +struct in_ifaddr *inet_lookup_ifaddr_rcu(struct net *net, __be32 addr) > > +{ > > + u32 hash = inet_addr_hash(net, addr); > > + struct in_ifaddr *ifa; > > + > > + hlist_for_each_entry_rcu(ifa, &inet_addr_lst[hash], hash) > > + if (ifa->ifa_local == addr && > > + net_eq(dev_net(ifa->ifa_dev->dev), net)) > > + return ifa; > > + > > + return NULL; > > +} > > +
Thank you for reviewing this! > Any particular reason you do not use this helper to replace the lookup > in __ip_dev_find() ? uh, I just missed that opportunity. I'll send a v2, thanks! Paolo