Ok fair enough. Will only disable GRO in the driver. Tests were done using "ethtool -K eth0 gro off" and on.
On Fri, 2017-09-15 at 17:03 -0700, Eric Dumazet wrote: > On Fri, 2017-09-15 at 15:54 -0700, Florian Fainelli wrote: > > On September 15, 2017 3:22:18 PM PDT, Rosen Penev <ros...@gmail.com > > > > > wrote: > > > On a linksys E1200v1 (actually a crossflashed E1000v2), the > > > > offloading > > > features give no measurable benefit to speed or latency. > > > Furthermore, > > > disabling GRO actually improves iperf performance by a whoppimg > > > > 3mbps. > > > > Do you have a way to generate gigabit tests and see what results > > you > > are getting? We probably are not going to see a 30% improvement > > just > > by extrapolation. > > > > +1 > > It seems silly to remove NETIF_F_SG | NETIF_F_IP_CSUM | > NETIF_F_IPV6_CSUM from dev->features, yet leave the dead-code in the > driver to handle these features. > > And of course GRO was not removed, meaning the bench results were non > conclusive. > > >
