Re: [PATCH net] sctp: potential read out of bounds in sctp_ulpevent_type_enabled()

[David Miller]

From: Dan Carpenter <dan.carpen...@oracle.com>
Date: Wed, 13 Sep 2017 12:20:28 +0300

> @@ -154,7 +154,11 @@ static inline int sctp_ulpevent_type_enabled(__u16 
> sn_type,
>                                            struct sctp_event_subscribe *mask)
>  {
>       char *amask = (char *) mask;
> -     return amask[sn_type - SCTP_SN_TYPE_BASE];
> +     int offset = sn_type - SCTP_SN_TYPE_BASE;

Please use reverse-christmas-tree local variable ordering.

Thank you.