On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote: > On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: > > Different namespace application might require enable TCP Fast Open > > feature independently of the host. > > > > Poor changelog, no actual description / list of sysctls that are moved > to per netns. > > And looking at the patch, it seems your conversion is not complete. > > So I will ask you to provide more evidence that you tested your patch > next time you submit it.
I suggest you move one sysctl at a time, in a patch series. It will be easier to document and test for you, and review for us. Thanks.
