On 09/01/2017 10:55 AM, Andrew Lunn wrote:
> Hi Florian
>
>>>> tc bind dev sw0p0 queue 0 dev eth0 queue 16
>
> It this the eth0 i don't like here. Why not in the implementation just
> use something like netdev_master_upper_dev_get('sw0p0')? Or does
>
> tc bind dev sw0p0 queue 0 dev lo queue 16
>
> make sense?
Last I brought this up with Jiri that we should link DSA network devices
to their master network deviecs with netdev_upper_dev_link() he said
this was not appropriate for DSA slave network devices, but I can't
remember why, I would assume that any stacked device set up would do that.
In any case, we need to establish a mapping so we have to specify at
least the target device's queue number. It is quite similar in premise
to e.g: enslaving a network device to a bridge port:
ip link set dev eth0 master br0
Thanks
--
Florian
