On 30/08/17 15:15, Jamal Hadi Salim wrote: > On 17-08-30 05:48 AM, Nikolay Aleksandrov wrote: >> Hi all, >> I went over all qdiscs' init, destroy and reset callbacks and found the >> issues fixed in each patch. Mostly they are null pointer dereferences due >> to uninitialized timer (qdisc watchdog) or double frees due to ->destroy >> cleaning up a second time. There's more information in each patch. >> I've tested these by either sending wrong attributes from user-spaces, no >> attributes or by simulating memory alloc failure where applicable. Also >> tried all of the qdiscs as a default qdisc. >> >> Most of these bugs were present before commit 87b60cfacf9f, I've tried to >> include proper fixes tags in each patch. >> >> I haven't included individual patch acks in the set, I'd appreciate it if >> you take another look and resend them. >> > > > Hi Nik, > > For all patches: > > Acked-by: Jamal Hadi Salim <j...@mojatatu.com> > > Would you please consider adding all the the tests > you used to create the oopses in selftests? It will ensure this > embarassing bugs get caught should they ever happen again. > If you need help ping Lucas on Cc. > > cheers, > jamal
Hi, Sure, I'll make the tests and send patches for tc selftests, using the infra at tools/testing/selftests/tc-testing. Thanks!
