From: Xin Long <lucien....@gmail.com> Date: Sat, 26 Aug 2017 20:10:10 +0800
> Now it doesn't check for the cached route expiration in ipv6's > dst_ops->check(), because it trusts dst_gc that would clean the > cached route up when it's expired. > > The problem is in dst_gc, it would clean the cached route only > when it's refcount is 1. If some other module (like xfrm) keeps > holding it and the module only release it when dst_ops->check() > fails. > > But without checking for the cached route expiration, .check() > may always return true. Meanwhile, without releasing the cached > route, dst_gc couldn't del it. It will cause this cached route > never to expire. > > This patch is to set dst.obsolete with DST_OBSOLETE_KILL in .gc > when it's expired, and check obsolete != DST_OBSOLETE_FORCE_CHK > in .check. > > Note that this is even needed when ipv6 dst_gc timer is removed > one day. It would set dst.obsolete in .redirect and .update_pmtu > instead, and check for cached route expiration when getting it, > just like what ipv4 route does. > > Reported-by: Jianlin Shi <ji...@redhat.com> > Signed-off-by: Xin Long <lucien....@gmail.com> > Acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Applied and queued up for -stable, thanks.
