On Mon, 28 Aug 2017 18:18:04 -0400 Jamal Hadi Salim <j...@mojatatu.com> wrote:
> Alex, > > I think we should get rid of these fprintfs instead of fixing them. > They were originally intended to be debug outputs. > > cheers, > jamal > > On 17-08-28 03:07 PM, Alexander Aring wrote: > > This patch uses the usually IEEE format to display an ethertype which is > > 4-digits and every digit in upper case. > > > > Signed-off-by: Alexander Aring <ar...@mojatatu.com> > > --- > > tc/m_ife.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tc/m_ife.c b/tc/m_ife.c > > index e05e2276..7b57130e 100644 > > --- a/tc/m_ife.c > > +++ b/tc/m_ife.c > > @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int > > *argc_p, char ***argv_p, > > NEXT_ARG(); > > if (get_u16(&ife_type, *argv, 0)) > > invarg("ife type is invalid", *argv); > > - fprintf(stderr, "IFE type 0x%x\n", ife_type); > > + fprintf(stderr, "IFE type 0x%04X\n", ife_type); > > user_type = 1; > > } else if (matches(*argv, "dst") == 0) { > > NEXT_ARG(); > > > For iproute commands the show output is supposed to match the corresponding set inputs.