Re: [PATCH net-next] hinic: uninitialized variable in hinic_api_cmd_init()

[Aviad Krawczyk]

On 8/24/2017 1:47 PM, Dan Carpenter wrote:
> We never set the error code in this function.
> 
> Fixes: eabf0fad81d5 ("net-next/hinic: Initialize api cmd resources")
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
> 
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c 
> b/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> index 8901801fe426..c40603a183df 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> @@ -941,6 +941,7 @@ int hinic_api_cmd_init(struct hinic_api_cmd_chain **chain,
>               if (IS_ERR(chain[chain_type])) {
>                       dev_err(&pdev->dev, "Failed to create chain %d\n",
>                               chain_type);
> +                     err = PTR_ERR(chain[chain_type]);
>                       goto err_create_chain;
>               }
>       }
> 
> 

Thanks a lot, Reviewed-by: Aviad Krawczyk <aviad.krawc...@huawei.com>