On Tue, Aug 15, 2017 at 4:09 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > From: Eric Dumazet <eduma...@google.com> > > Based on a syzkaller report [1], I found that a per cpu allocation > failure in snmp6_alloc_dev() would then lead to NULL dereference in > ip6_route_dev_notify(). > > It seems this is a very old bug, thus no Fixes tag in this submission.
It should be introduced by my commit which introduces these in6_dev_put(). > > Let's add in6_dev_put_clear() helper, as we will probably use > it elsewhere (once available/present in net-next) > I don't understand why not just check ->rt6i_idev against NULL for -net? Ideally, we should let notifiers handle this, when we fail in one of those notifiers, we should only rollback those succeeded rather than all of them, but this may require more changes. Thanks.
