On Wed, Aug 16, 2017 at 10:44 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Wed, 2017-08-16 at 06:31 -0700, Tonghao Zhang wrote: >> Because we remove the tcp_tw_recycle support in the commit > > >> 4396e46187c ('tcp: remove tcp_tw_recycle') and also delete >> the code 'af_ops->route_req' for sysctl_tw_recycle in tcp_conn_request. >> Now when we call the 'af_ops->route_req', the dist always is >> NULL, and we remove the unnecessay check. > > Thanks for these patches. > > You forgot : > > 1) a cover letter ( [PATCH next-next 0/2] tcp: .... > > 2) clearly state which tree you are targeting > ( read Documentation/networking/netdev-FAQ.txt ) Thanks, I do this in v2
> 3) Also, I would also have removed tcp_peer_is_proven() > since it is also called with dst=NULL Thanks for your work. > >