On Tue, 2017-08-15 at 13:08 +0000, Boris Pismenny wrote: > Hi Eric,
> > The IPV6_ADDRFORM socket option assumes that when > (sk->sk_protocol == IPPROTO_TCP) > then the sk_proto is set to tcpv6_prot and it replaces it with tcp_prot. > > This patch ensures that the IPV6_ADDRFORM socket option doesn't replace > the socket's sk_prot to tcp when it is not expected. For example, TLS sockets > also replace sk_prot, and we need to prevent IPV6_ADDRFORM from > overriding these. > > Are you suggesting that each socket protocol will provide a method that > converts it from IPv6 to IPv4? I am just saying IPV6_ADDRFORM is becoming spaghetti code, and maybe this is time to make it modular. The UDP or TCP magic really should be implemented in TCP or UDP files. (Who knows maybe one day SCTP or DCCP will support IPVADDRFORM)
