On Sun, Aug 13, 2017 at 05:25:21PM -0700, David Miller wrote: > From: Ohad Oz <oh...@mellanox.com> > Date: Sun, 13 Aug 2017 15:26:56 +0000 > > > > > > >> -----Original Message----- > >> From: Leon Romanovsky [mailto:l...@kernel.org] > >> Sent: Saturday, August 12, 2017 5:37 PM > >> To: Ohad Oz <oh...@mellanox.com> > >> Cc: da...@davemloft.net; netdev@vger.kernel.org; j...@resnulli.us; Saeed > >> Mahameed <sae...@mellanox.com>; Vadim Pasternak > >> <vad...@mellanox.com>; system-sw-low-level <system-sw-low- > >> le...@mellanox.com> > >> Subject: Re: [patch v1 1/2] Allow Mellanox network vendor to be configured > >> if only I2C bus is configured > >> > >> On Thu, Aug 10, 2017 at 05:11:51PM +0000, Ohad Oz wrote: > >> > Patch allows Mellanox devices on system with no PCI, but with I2C only. > >> > > >> > >> Did you test mlx5 device on such system? Did it work for you? > > > > Yes, I did. With PCI config set to disable mlx5 drivers are not built. > > Only the following: > > /build/drivers/net/Ethernet/mellanox/mlxsw/mlxsw_core.ko > > /build/drivers/net/Ethernet/mellanox /mlxsw/mlxsw_i2c.ko > > /build/drivers/net/Ethernet/mellanox /mlxsw/mlxsw_minimal.ko > > > > While with both options on all drivers are built inc mlx5. > > I'm not so sure he's interested if things build or not. > > He's asking you if you actually used a Mellanox device with this > driver with PCI disabled and only I2C available.
Thanks David, you are absolutely right. The commit message and more important, Kconfig entry, is misleading the potential users by promising them that all devices under drivers/net/ethernet/mellanox folder are working with i2c. I have no technical objection to the idea of this patch, but it needs to be resubmitted after Ohad ensures that mlx4/mlx5 are not visible in menuconfig for i2c systems and he fixes Kconfig description together with commit log. Thanks
signature.asc
Description: PGP signature
