Hi Willem, because we change the CHECKSUM_NONE to CHECKSUM_UNNECESSARY
in skb_needs_check(), I can't revert 6e7bc478c9a0
("net: skb_needs_check() accepts CHECKSUM_NONE for tx"). I change it
directly and resubmit it.
On Fri, Aug 11, 2017 at 1:03 AM, Willem de Bruijn
<[email protected]> wrote:
> On Wed, Aug 9, 2017 at 6:02 PM, Tonghao Zhang <[email protected]>
> wrote:
>> Thanks for your work.
>
> You, too.
>
>> On Thu, Aug 10, 2017 at 2:30 AM, Willem de Bruijn
>> <[email protected]> wrote:
>>> On Wed, Aug 9, 2017 at 5:04 AM, Tonghao Zhang <[email protected]>
>>> wrote:
>>>> This patch reverts the commit 6e7bc478c9a0
>>>> ("net: skb_needs_check() accepts CHECKSUM_NONE for tx"),
>>>> because we removed the UFO support.
>>>>
>>>> Cc: Eric Dumazet <[email protected]>
>>>> Cc: Willem de Bruijn <[email protected]>
>>>> Signed-off-by: Tonghao Zhang <[email protected]>
>>>
>>>
>>> I would wait until net is merged into net-next. This will cause a conflict.
>>>
>>> Also, while logically equivalent, it is not a real revert (as in `git
>>> revert $SHA1`) of that patch.
>>>
>>> Aside from those concerns, I agree that the original patch is no
>>> longer needed now that UFO is reverted.
>
> Please do resubmit the revert patch once net has been merged into net-next.
