On Sun, Aug 6, 2017 at 4:42 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote: > On 17-08-05 12:31 AM, Cong Wang wrote: >> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c >> index e655221c654e..afd099727aea 100644 >> --- a/net/sched/cls_api.c >> +++ b/net/sched/cls_api.c >> @@ -104,6 +104,10 @@ static int tfilter_notify(struct net *net, struct >> sk_buff *oskb, >> struct nlmsghdr *n, struct tcf_proto *tp, >> unsigned long fh, int event, bool unicast); >> +static int tfilter_del_notify(struct net *net, struct sk_buff *oskb, >> + struct nlmsghdr *n, struct tcf_proto *tp, >> + unsigned long fh, bool unicast, bool *last); >> + > > > Any reason not to move the functin up here and getting rid of this > forward declaration?
It calls tcf_fill_node() which is defined at line 643, it is called at line 602. Moving it requires moves the rest, this makes this patch unnecessarily bigger. Why not make it a separate patch?
