On Fri, Jul 28, 2017 at 3:59 PM, Natale Patriciello
<natale.patricie...@gmail.com> wrote:
> TCP Wave (TCPW) replaces the window-based transmission paradigm of the
> standard TCP with a burst-based transmission, the ACK-clock scheduling
> with a self-managed timer and the RTT-based congestion control loop
> with an Ack-based Capacity and Congestion Estimation (ACCE) module. In
> non-technical words, it sends data down the stack when its internal
> timer expires, and the timing of the received ACKs contribute to
> updating this timer regularly.
>
> It is the first TCP congestion control that uses the timing constraint
> developed in the Linux kernel.
>
> Signed-off-by: Natale Patriciello <natale.patricie...@gmail.com>
> Tested-by: Ahmed Said <ahmed.s...@uniroma2.it>
> ---
> MAINTAINERS | 6 +
> net/ipv4/Kconfig | 16 +
> net/ipv4/Makefile | 1 +
> net/ipv4/tcp_output.c | 4 +-
> net/ipv4/tcp_wave.c | 914
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 940 insertions(+), 1 deletion(-)
> create mode 100644 net/ipv4/tcp_wave.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 767e9d202adf..39c57bdc417d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12427,6 +12427,12 @@ W: http://tcp-lp-mod.sourceforge.net/
> S: Maintained
> F: net/ipv4/tcp_lp.c
>
> +TCP WAVE MODULE
> +M: "Natale Patriciello" <natale.patricie...@gmail.com>
> +W: http://tcp-lp-mod.sourceforge.net/
This URL does not work for me... I get "Unable to connect to database server".
> @@ -2522,7 +2522,9 @@ void tcp_push_one(struct sock *sk, unsigned int mss_now)
> {
> struct sk_buff *skb = tcp_send_head(sk);
>
> - BUG_ON(!skb || skb->len < mss_now);
> + /* Don't be forced to send not meaningful data */
> + if (!skb || skb->len < mss_now)
> + return;
>
> tcp_write_xmit(sk, mss_now, TCP_NAGLE_PUSH, 1, sk->sk_allocation);
> }
This seems unrelated to the rest of the patch, and should probably be
its own patch? Also, IMHO it would be better to leave at least a
WARN_ON or WARN_ON_ONCE here, rather than completely turning this into
a silent failure.
thanks,
neal
