On Mon, Jul 24, 2017 at 1:34 PM, David Miller <da...@davemloft.net> wrote: > From: Shaohua Li <s...@kernel.org> > Date: Tue, 18 Jul 2017 12:03:37 -0700 > >> + /* Since this is being sent on the wire obfuscate hash a bit >> + * to minimize possbility that any useful information to an >> + * attacker is leaked. Only lower 20 bits are relevant. >> + */ >> + rol32(hash, 16); > > This doesn't help anything at all.
I believe the above code is copy-n-pasted from ip6_make_flowlabel() (with few adjustments). Don't know why we can't refactor that function for reuse.
