> +static int mtk_clk_enable(struct mtk_eth *eth)
> +{
> + int clk, ret;
> +
> + for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> + if (eth->clks[clk]) {
> + ret = clk_prepare_enable(eth->clks[clk]);
> + if (ret)
> + goto err_disable_clks;
> + }
> + }
> +
> + return 0;
> +
> +err_disable_clks:
> + while (--clk >= 0) {
> + if (eth->clks[clk])
> + clk_disable_unprepare(eth->clks[clk]);
> + }
> +
> + return ret;
> +}
> +
> static int mtk_hw_init(struct mtk_eth *eth)
> {
> int i, val;
> @@ -1847,10 +1881,8 @@ static int mtk_hw_init(struct mtk_eth *eth)
> pm_runtime_enable(eth->dev);
> pm_runtime_get_sync(eth->dev);
>
> - clk_prepare_enable(eth->clks[MTK_CLK_ETHIF]);
> - clk_prepare_enable(eth->clks[MTK_CLK_ESW]);
> - clk_prepare_enable(eth->clks[MTK_CLK_GP1]);
> - clk_prepare_enable(eth->clks[MTK_CLK_GP2]);
> + mtk_clk_enable(eth);
> +
mtk_clk_enable() returns an error code. It is probably a good idea to
use it, especially if it could be EPRODE_DEFER.
Andrew
