On Wed, Jul 05, 2017 at 03:10:53AM -0400, Matthias Rosenfelder wrote:
> Hi,
>
> In do_tls_getsockopt_tx():
>
> if (len == sizeof(crypto_info)) {
>
> should be
>
> if (len == sizeof(*crypto_info)) {
>
> as crypto_info is of pointer type. Or am I missing something?
No, you're right. It should be "sizeof(*crypto_info)".
It's hard for Smatch to catch these sorts of bugs because Sparse
sometimes just gives Smatch a number literal instead of a sizeof()
expression. I think Coccinelle can catch these kinds of bugs?
regards,
dan carpenter
