Re: [PATCH RFC 1/2] skbuff: Function to send an skbuf on a socket

[David Miller]

From: Tom Herbert <t...@herbertland.com>
Date: Thu, 29 Jun 2017 11:27:04 -0700

> +int skb_send_sock(struct sk_buff *skb, struct socket *sock, unsigned int 
> offset)
> +{
> +     unsigned int sent = 0;
> +     unsigned int ret;
> +     unsigned short fragidx;

Please use reverse christmas tree ordering for these local variables.

> +     /* Deal with head data */
> +     while (offset < skb_headlen(skb)) {
> +             size_t len = skb_headlen(skb) - offset;
> +             struct kvec kv;
> +             struct msghdr msg;

Likewise.