From: Brian Haley <[EMAIL PROTECTED]>
Date: Tue, 01 Aug 2006 13:06:03 -0400
> The variable 'err' is set in rawv6_bind() before the address check fails
> instead of after, moved inside if() statement.
>
> Signed-off-by: Brian Haley <[EMAIL PROTECTED]>
This is a common C idiom in the kernel:
err = -EWHATEVER;
if (error_condition)
goto out;
err = 0;
out:
unlock_stuff();
return err;
Every other path going from this location in rawv6_bind()
will clear err to zero, so your patch also doesn't fix any
bug.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
