On Wed, 28 Jun 2017 01:21:44 +0200, Simon Horman wrote:
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c
> b/drivers/net/ethernet/netronome/nfp/flower/offload.c
> index 9127c28ea9c3..8ad72f57493d 100644
> --- a/drivers/net/ethernet/netronome/nfp/flower/offload.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c
> @@ -45,6 +45,145 @@
> #include "../nfp_net.h"
> #include "../nfp_port.h"
>
> +static bool nfp_flower_check_lower_than_mac(struct tc_cls_flower_offload *f)
> +{
> + return dissector_uses_key(f->dissector,
> + FLOW_DISSECTOR_KEY_IPV4_ADDRS) ||
> + dissector_uses_key(f->dissector,
> + FLOW_DISSECTOR_KEY_IPV6_ADDRS) ||
> + dissector_uses_key(f->dissector,
> + FLOW_DISSECTOR_KEY_PORTS) ||
> + dissector_uses_key(f->dissector, FLOW_DISSECTOR_KEY_ICMP);
> +}
Nit: should this be named higher than mac?