On Tue, Jun 27, 2017 at 10:41:50AM -0600, Jason Gunthorpe wrote: > On Tue, Jun 27, 2017 at 12:21:29PM +0300, Leon Romanovsky wrote: > > > What will be the output of such command? > > > $ rdma dev show mlx5_4 > > > > ip-like style: > > > > $ rdma dev show mlx5_4 > > 5: mlx5_4: > > caps: <BAD_PKEY_CNTR, BAD_QKEY_CNTR, CHANGE_PHY_PORT, > > PORT_ACTIVE_EVENT, SYS_IMAGE_GUID, RC_RNR_NAK_GEN, MEM_WINDOW, UD_IP_CSUM, > > UD_TSO, XRC, MEM_MGT_EXTENSIONS, BLOCK_MULTICAST_LOOPBACK, > > MEM_WINDOW_TYPE_2B, RAW_IP_CSUM, SIGNATURE_HANDOVER, VIRTUAL_FUNCTION> > > $ rdma link show mlx5_3 > > 4/1: mlx5_3/1: > > caps: <CM, IP_BASED_GIDS> > > I think that is better, maybe it should only show under some kind of > verbose mode, I don't know, it depends what other stuff ends up being > displayed.. > > Are you going to dump the gid table and pkey table too in one of these > commands?
My initial plan was to put all parsers under their respective names, in the similar way as I did for caps: $ rdma dev show mlx5_4 caps So for large dumps, I'm going to use that technique again and maybe print summary as a default. For example, for gids, we can print utilization as a summary while whole table if someone really wants it: $ rdma link show mlx5_4/1 gids <index> Something like that. Thanks > > Jason
signature.asc
Description: PGP signature
