On Tue, Aug 01, 2006 at 04:10:23PM +0200, Jiri Benc wrote:
> On Sat, 29 Jul 2006 23:56:45 +0200, Karol Lewandowski wrote:
> The fix is not easy. In fact, it's as hard as to fix it by implementing
> a feature that allows to use different rate control algorithm for each
> device. Given the fact the problem doesn't occur in normal conditions,
> it's a low priority for me (unless there is a volunteer to fix it). It
> needs to be fixed before d80211 is merged, though (sigh).
I volunteer to provide this simple fix:
--- ieee80211.c.orig 2006-08-01 16:24:41.000000000 +0200
+++ ieee80211.c 2006-08-01 16:53:01.000000000 +0200
@@ -4462,7 +4462,8 @@
if (result < 0)
goto fail_if_sysfs;
- if (rate_control_initialize(local) < 0) {
+ result = rate_control_initialize(local);
+ if (result < 0) {
printk(KERN_DEBUG "%s: Failed to initialize rate control "
"algorithm\n", dev->name);
goto fail_rate;
Without that ieee80211_register_hw was returning value from previous
check:
>>> result = ieee80211_sysfs_add_netdevice(dev);
rtnl_unlock();
if (result < 0)
goto fail_if_sysfs;
if (rate_control_initialize(local) < 0) {
printk(KERN_DEBUG "%s: Failed to initialize rate control "
"algorithm\n", dev->name);
goto fail_rate;
}
This fixes that oops. Problem remains, though. I suppose that oops
would happen anyway if someone would do:
# modprobe rate_control # loads 80211
# modprobe rt2500pci
(Driver needs to initialize cleanly here, mine has some (different)
problem so I'm just guessing here...)
# rmmod rate_control
<oops here>, I think.
> I suppose you don't have automatic loading of modules enabled, right?
Yes, I've disabled it.
--
This signature intentionally says nothing.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
