> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Wednesday, June 21, 2017 11:12 AM > To: Leon Romanovsky <l...@kernel.org> > Cc: Doug Ledford <dledf...@redhat.com>; linux-r...@vger.kernel.org; Tung, > Chien Tin <chien.tin.t...@intel.com>; Steve Wise > <sw...@opengridcomputing.com>; Stephen Hemminger > <step...@networkplumber.org>; Jiri Pirko <j...@mellanox.com>; Ariel Almog > <ari...@mellanox.com>; Linux Netdev <netdev@vger.kernel.org>; Leon > Romanovsky <leo...@mellanox.com> > Subject: Re: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device > definitions to UAPI > > On Wed, Jun 21, 2017 at 09:05:22AM +0300, Leon Romanovsky wrote: > > RDMA_NL_IWCM, > > RDMA_NL_RSVD, > > RDMA_NL_LS, /* RDMA Local Services */ > > + /* > > + * RDMA_NL_I40IW not in use and it was added here by mistake, > > + * but we need to keep it anyway, because it is UAPI and for > > + * unknown reasons, someone in the field decided to replace "5" > > + * with this define. > > + */ > > RDMA_NL_I40IW, > > Since this doesn't do anything, never did anything, I think you should just > delete it. Anything in userspace that refers to this name is unconditionally > broken and a compile failure is the better choice. > > Jason
I agree. Please delete RDMA_NL_I40IW. Chien
