From: Ben Greear <[EMAIL PROTECTED]>
Date: Fri, 28 Jul 2006 14:55:17 -0700

> The skb_bond method assigns skb->dev when it does the 'keep',
> but the VLAN code immediately over-writes the skb->dev when
> searching for the vlan device.
> 
> What is the purpose of assinging skb->dev to the master device?

This makes me consider this patch highly dubious, at best.

The whole intention of bonding on input is to make all packets
incoming on the individual bond slaves to look like they come in via
the master device.

Therefore, even when the bond slaves are VLAN devices, in the end the
skb->dev should be the bond master device _not_ the VLAN device.

I'm not applying this patch, it doesn't look correct at all.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to