> -----Original Message-----
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of Johannes Berg
> Sent: Thursday, June 15, 2017 5:28 PM
> To: netdev@vger.kernel.org
> Cc: Johannes Berg
> Subject: [RFC v2] networking: convert many more places to skb_put_zero()
>
> From: Johannes Berg <johannes.b...@intel.com>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index ea2601501654..aaac2660aaf7 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -1478,10 +1478,9 @@ void *sctp_addto_chunk(struct sctp_chunk *chunk,
> int len, const void *data)
> int chunklen = ntohs(chunk->chunk_hdr->length);
> int padlen = SCTP_PAD4(chunklen) - chunklen;
>
> - padding = skb_put(chunk->skb, padlen);
> + padding = skb_put_zero(chunk->skb, padlen);
"padding" will become unused.
I know this place when I check.
> target = skb_put(chunk->skb, len);
>
> - memset(padding, 0, padlen);
> memcpy(target, data, len);
>
> /* Adjust the chunk length field. */
> --
> 2.11.0
