When CONFIG_KASAN is used, we consume a lot of extra stack space:
drivers/mtd/chips/cfi_cmdset_0020.c: In function 'do_write_buffer':
drivers/mtd/chips/cfi_cmdset_0020.c:603:1: error: the frame size of 2184 bytes
is larger than 1536 bytes [-Werror=frame-larger-than=]
drivers/mtd/chips/cfi_cmdset_0020.c: In function 'cfi_staa_erase_varsize':
drivers/mtd/chips/cfi_cmdset_0020.c:972:1: error: the frame size of 1936 bytes
is larger than 1536 bytes [-Werror=frame-larger-than=]
drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer':
drivers/mtd/chips/cfi_cmdset_0001.c:1841:1: error: the frame size of 1776 bytes
is larger than 1536 bytes [-Werror=frame-larger-than=]
This marks some functions as noinline_if_stackbloat to keep reduce the
overall stack size.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
drivers/mtd/chips/cfi_cmdset_0020.c | 8 ++++----
include/linux/mtd/map.h | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c
b/drivers/mtd/chips/cfi_cmdset_0020.c
index 7d342965f392..5eee5e883f55 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -244,7 +244,7 @@ static struct mtd_info *cfi_staa_setup(struct map_info *map)
}
-static inline int do_read_onechip(struct map_info *map, struct flchip *chip,
loff_t adr, size_t len, u_char *buf)
+static noinline_if_stackbloat int do_read_onechip(struct map_info *map, struct
flchip *chip, loff_t adr, size_t len, u_char *buf)
{
map_word status, status_OK;
unsigned long timeo;
@@ -728,7 +728,7 @@ cfi_staa_writev(struct mtd_info *mtd, const struct kvec
*vecs,
}
-static inline int do_erase_oneblock(struct map_info *map, struct flchip *chip,
unsigned long adr)
+static noinline_if_stackbloat int do_erase_oneblock(struct map_info *map,
struct flchip *chip, unsigned long adr)
{
struct cfi_private *cfi = map->fldrv_priv;
map_word status, status_OK;
@@ -1029,7 +1029,7 @@ static void cfi_staa_sync (struct mtd_info *mtd)
}
}
-static inline int do_lock_oneblock(struct map_info *map, struct flchip *chip,
unsigned long adr)
+static noinline_if_stackbloat int do_lock_oneblock(struct map_info *map,
struct flchip *chip, unsigned long adr)
{
struct cfi_private *cfi = map->fldrv_priv;
map_word status, status_OK;
@@ -1175,7 +1175,7 @@ static int cfi_staa_lock(struct mtd_info *mtd, loff_t
ofs, uint64_t len)
}
return 0;
}
-static inline int do_unlock_oneblock(struct map_info *map, struct flchip
*chip, unsigned long adr)
+static noinline_if_stackbloat int do_unlock_oneblock(struct map_info *map,
struct flchip *chip, unsigned long adr)
{
struct cfi_private *cfi = map->fldrv_priv;
map_word status, status_OK;
diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h
index 3aa56e3104bb..29db74314db8 100644
--- a/include/linux/mtd/map.h
+++ b/include/linux/mtd/map.h
@@ -316,7 +316,7 @@ static inline map_word map_word_or(struct map_info *map,
map_word val1, map_word
return r;
}
-static inline int map_word_andequal(struct map_info *map, map_word val1,
map_word val2, map_word val3)
+static noinline_if_stackbloat int map_word_andequal(struct map_info *map,
map_word val1, map_word val2, map_word val3)
{
int i;
@@ -328,7 +328,7 @@ static inline int map_word_andequal(struct map_info *map,
map_word val1, map_wor
return 1;
}
-static inline int map_word_bitsset(struct map_info *map, map_word val1,
map_word val2)
+static noinline_if_stackbloat int map_word_bitsset(struct map_info *map,
map_word val1, map_word val2)
{
int i;
@@ -362,7 +362,7 @@ static inline map_word map_word_load(struct map_info *map,
const void *ptr)
return r;
}
-static inline map_word map_word_load_partial(struct map_info *map, map_word
orig, const unsigned char *buf, int start, int len)
+static noinline_if_stackbloat map_word map_word_load_partial(struct map_info
*map, map_word orig, const unsigned char *buf, int start, int len)
{
int i;
@@ -392,7 +392,7 @@ static inline map_word map_word_load_partial(struct
map_info *map, map_word orig
#define MAP_FF_LIMIT 8
#endif
-static inline map_word map_word_ff(struct map_info *map)
+static noinline_if_stackbloat map_word map_word_ff(struct map_info *map)
{
map_word r;
int i;
--
2.9.0
From reviews-return-15279-archive=mail-archive....@impala.incubator.apache.org
Wed Jun 14 14:20:27 2017
Return-path:
<reviews-return-15279-archive=mail-archive....@impala.incubator.apache.org>
Envelope-to: arch...@mail-archive.com
Delivery-date: Wed, 14 Jun 2017 14:20:27 -0700
Received: from c7-b.mxthunder.net ([208.53.48.218])
by mail-archive.com with esmtp (Exim 4.76)
(envelope-from
<reviews-return-15279-archive=mail-archive....@impala.incubator.apache.org>)
id 1dLFiE-00088o-UT
for arch...@mail-archive.com; Wed, 14 Jun 2017 14:20:27 -0700
Received: by bolt10b.mxthunder.net (Postfix, from userid 12345)
id 3wp00Q1VpHz1wVk3; Wed, 14 Jun 2017 14:20:15 -0700 (PDT)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
by bolt10b.mxthunder.net (Postfix) with SMTP id 3wp00G4kQsz1wVhX
for <arch...@mail-archive.com>; Wed, 14 Jun 2017 14:20:14 -0700 (PDT)
Received: (qmail 87594 invoked by uid 500); 14 Jun 2017 21:20:14 -0000
Mailing-List: contact reviews-h...@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-h...@impala.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscr...@impala.incubator.apache.org>
List-Post: <mailto:revi...@impala.incubator.apache.org>
List-Id: <reviews.impala.incubator.apache.org>
Delivered-To: mailing list revi...@impala.incubator.apache.org
Received: (qmail 87574 invoked by uid 99); 14 Jun 2017 21:20:13 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO
spamd1-us-west.apache.org) (209.188.14.142)
by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Jun 2017 21:20:13 +0000
Received: from localhost (localhost [127.0.0.1])
by spamd1-us-west.apache.org (ASF Mail Server at
spamd1-us-west.apache.org) with ESMTP id 7CC1CC136E
for <revi...@impala.apache.org>; Wed, 14 Jun 2017 21:20:13 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.362
X-Spam-Level:
X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31
tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port
10024)
with ESMTP id pK_v2_FBcN1y for <revi...@impala.apache.org>;
Wed, 14 Jun 2017 21:20:12 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal
(ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with
ESMTPS id 116DB5FB29
for <revi...@impala.incubator.apache.org>; Wed, 14 Jun 2017 21:20:11
+0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id
v5ELKA22015426;
Wed, 14 Jun 2017 21:20:10 GMT
Message-Id: <201706142120.v5ELKA22015426@ip-10-146-233-104.ec2.internal>
Date: Wed, 14 Jun 2017 21:20:10 +0000
From: "Lars Volker (Code Review)" <ger...@cloudera.org>
To: Pooja Nilangekar <pooja.nilange...@cloudera.com>, impala...@cloudera.com,
revi...@impala.incubator.apache.org
Reply-To: l...@cloudera.com
X-Gerrit-MessageType: comment
Subject:
=?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5061=3A_Populate_null_count_in_parquet=3A=3Astatistics=0A?=
X-Gerrit-Change-Id: I4c49a63af84c2234f0633be63206cb52eb7e8ebb
X-Gerrit-ChangeURL: <http://gerrit.cloudera.org:8080/7058>
X-Gerrit-Commit: 85dedd6fbc82c98a1d176f8a6e578caac9e61c0c
In-Reply-To:
<gerrit.1496425571000.i4c49a63af84c2234f0633be63206cb52eb7e8...@gerrit.cloudera.org>
References:
<gerrit.1496425571000.i4c49a63af84c2234f0633be63206cb52eb7e8...@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
X-MXTHUNDER-Identifier:
<201706142120.v5ELKA22015426@ip-10-146-233-104.ec2.internal>
X-MXTHUNDER-IP-Rating: 0, 140.211.11.3, Ugly c=0.970837 p=-0.987039 Source
White
X-MXTHUNDER-Scan-Result: 100
X-MXTHUNDER-Rules:
100-5946619-4001-4015-m
100-5946619-0-4039-f
X-MXTHUNDER-Group: Bulk Mail
Content-Transfer-Encoding: quoted-printable
Lars Volker has posted comments on this change.
Change subject: IMPALA-5061: Populate null_count in parquet::statistics
......................................................................
Patch Set 8: Code-Review+1
--=20
To view, visit http://gerrit.cloudera.org:8080/7058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c49a63af84c2234f0633be63206cb52eb7e8ebb
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-HasComments: No
