From: Jeff Kirsher <[email protected]> Date: Mon, 12 Jun 2017 15:38:36 -0700
> From: Jacob Keller <[email protected]> > > A recent commit to refactor the driver and remove the hw_disabled_flags > field accidentally introduced two regressions. First, we overwrote > pf->flags which removed various key flags including the MSI-X settings. > > Additionally, it was intended that we have now two flags, > HW_ATR_EVICT_CAPABLe and HW_ATR_EVICT_ENABLED, but this was not done, > and we accidentally were mis-using HW_ATR_EVICT_CAPABLE everywhere. > > This patch adds the missing piece, HW_ATR_EVICT_ENABLED, and safely > updates pf->flags instead of overwriting it. > > Without this patch we will have many problems including disabling MSI-X > support, and we'll attempt to use HW ATR eviction on devices which do > not support it. > > Fixes: 47994c119a36 ("i40e: remove hw_disabled_flags in favor of using > separate flag bits", 2017-04-19) > Signed-off-by: Jacob Keller <[email protected]> > Tested-by: Andrew Bowers <[email protected]> > Signed-off-by: Jeff Kirsher <[email protected]> Applied, thanks Jeff.
