> From: Sven Eckelmann [mailto:s...@narfation.org] > Sent: Friday, June 9, 2017 3:23 PM > Subject: Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks > when fail to register_netdevice > > On Dienstag, 25. April 2017 20:03:20 CEST gfree.w...@foxmail.com wrote: > > From: Gao Feng <f...@ikuai8.com> > > > > Because the func batadv_softif_init_late allocate some resources and > > it would be invoked in register_netdevice. So we need to invoke the > > func batadv_softif_free instead of free_netdev to cleanup when fail to > > register_netdevice. > > > > Signed-off-by: Gao Feng <f...@ikuai8.com> > > --- > > net/batman-adv/soft-interface.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/batman-adv/soft-interface.c > > b/net/batman-adv/soft-interface.c index d042c99..90bf990 100644 > > --- a/net/batman-adv/soft-interface.c > > +++ b/net/batman-adv/soft-interface.c > > @@ -1011,7 +1011,7 @@ struct net_device *batadv_softif_create(struct net > *net, const char *name) > > if (ret < 0) { > > pr_err("Unable to register the batman interface '%s': %i\n", > > name, ret); > > - free_netdev(soft_iface); > > + batadv_softif_free(soft_iface); > > return NULL; > > } > > It looks to me like this change is invalid after David's change [1]. Can you > confirm that? > > Thanks, > Sven > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=cf1 > 24db566e6b036b8bcbe8decbed740bdfac8c6 [Gao Feng]
yes, this change is unnecessary. Best Regards Feng
