Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

[Andrew Lunn]

On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote:
> +#define MVMDIO_XSMI_MGNT_REG         0x0
> +#define  MVMDIO_XSMI_READ_VALID              BIT(29)
> +#define  MVMDIO_XSMI_BUSY            BIT(30)
> +#define MVMDIO_XSMI_ADDR_REG         0x8
> +#define  MVMDIO_XSMI_PHYADDR_SHIFT   16
> +#define  MVMDIO_XSMI_DEVADDR_SHIFT   21
> +#define  MVMDIO_XSMI_READ_OPERATION  (0x7 << 26)
> +#define  MVMDIO_XSMI_WRITE_OPERATION (0x5 << 27)

Hi Antoine

These two operations seem odd. Generally ops have the same shift.

      Andrew