Re: [PATCH 4/9] net: mvmdio: move the read valid check into its own function

[Antoine Tenart]

Hello,

On Wed, Jun 07, 2017 at 01:00:21PM +0300, Sergei Shtylyov wrote:
> On 6/7/2017 11:38 AM, Antoine Tenart wrote:
> > 
> > -   val = readl(dev->regs);
> > -   if (!(val & MVMDIO_SMI_READ_VALID)) {
> > +   if (orion_mdio_smi_is_read_valid(dev)) {
> >             dev_err(bus->parent, "SMI bus read not valid\n");
> 
>    I think you reversed the valuid/invalid sense in the new function's name.

Good catch, I'll fix this.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

signature.asc
Description: PGP signature