On 05/30/2017 12:55 PM, Vivien Didelot wrote: > Hi Florian, > > Florian Fainelli <f.faine...@gmail.com> writes: > >> I actually have a patch pending that adds support for HW >> insertion/extraction of switch tags (broadcom HW supports that) which >> require the orig_dev to be there so we know what features are supported >> by the master network device. > > Is orig_dev really needed in the tagging implementation, or only in the > layer above? (dsa_slave_xmit and dsa_switch_rcv.)
It's needed: https://github.com/ffainelli/linux/commits/switch-tag https://github.com/ffainelli/linux/commit/61f9ca70dd21bb8c1615f959934cd0ce80a2f3ce > >> Do you mind dropping this one from your patch series? > > I don't mind if they are actually needed in taggers. I'd wait for > reviews of the other patches before respinning though. > > Thanks, > > Vivien > -- Florian
