From: Jiri Pirko <j...@resnulli.us> Date: Fri, 26 May 2017 09:21:29 +0200
> From: Jiri Pirko <j...@mellanox.com> > > Alhough I believe that this create/nocreate dance is completelly > pointless, at least make it a bit nicer and easier to read. > Push the decision on what error value is returned to chain_get function > and use ERR macros. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> No, this is quite worse. You're leaving pointer error values in structures. That's extremely error prone. And as stated in the other thread, I don't think Cong's logic is strange or hard to understand at all.
