Re: [PATCHv2 net-next 5/5] dsa: mv88e6xxx: Enable/Disable SERDES on port enable/disable

[Vivien Didelot]

Hi Andrew,

Andrew Lunn <and...@lunn.ch> writes:

> +static int mv88e6xxx_port_enable(struct dsa_switch *ds, int port,
> +                              struct phy_device *phydev)
> +{
> +     struct mv88e6xxx_chip *chip = ds->priv;
> +     int err = 0;
> +
> +     mutex_lock(&chip->reg_lock);
> +     if (chip->info->ops->serdes_power)
> +             err = chip->info->ops->serdes_power(chip, port, true);
> +     mutex_unlock(&chip->reg_lock);
> +
> +     return err;
> +}

Please use your new mv88e6xxx_serdes_power() helper here.

> +
> +static void mv88e6xxx_port_disable(struct dsa_switch *ds, int port,
> +                                struct phy_device *phydev)
> +{
> +     struct mv88e6xxx_chip *chip = ds->priv;
> +
> +     mutex_lock(&chip->reg_lock);
> +     if (chip->info->ops->serdes_power)
> +             chip->info->ops->serdes_power(chip, port, false);
> +     mutex_unlock(&chip->reg_lock);
> +}

Idem, please print a message in case of error as well:

        if (mv88e6xxx_serdes_power())
                dev_err(...)


Thanks,

        Vivien