Re: [PATCH net-next 2/4] nfp: register ports as devlink ports

[Jiri Pirko]

Tue, May 23, 2017 at 05:12:45PM CEST, jakub.kicin...@netronome.com wrote:
>Extend nfp_port to contain devlink_port structures.  Register the
>ports to allow users inspecting device ports.
>
>Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com>
>Reviewed-by: Simon Horman <simon.hor...@netronome.com>
>---

[...]

>+void nfp_devlink_port_unregister(struct nfp_port *port)
>+{
>+      /* Due to unpleasant lock ordering we may see the port go away before
>+       * we have fully probed.

Could you elaborate on this a bit more please?


>+       */
>+      if (port->dl_port.registered)
>+              devlink_port_unregister(&port->dl_port);
>+}