From: Markus Elfring <elfr...@users.sourceforge.net> Date: Mon, 22 May 2017 15:45:31 +0200
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> --- net/rds/tcp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/rds/tcp.c b/net/rds/tcp.c index 431404dbdad1..b0348697dee5 100644 --- a/net/rds/tcp.c +++ b/net/rds/tcp.c @@ -431,10 +431,9 @@ static __net_init int rds_tcp_init_net(struct net *net) } else { tbl = kmemdup(rds_tcp_sysctl_table, sizeof(rds_tcp_sysctl_table), GFP_KERNEL); - if (!tbl) { - pr_warn("could not set allocate syctl table\n"); + if (!tbl) return -ENOMEM; - } + rtn->ctl_table = tbl; } tbl[RDS_TCP_SNDBUF].data = &rtn->sndbuf_size; -- 2.13.0
