On Sun, May 14, 2017 at 11:21 AM, Yuval Mintz <yuval.mi...@cavium.com> wrote: > Current memset is using incorrect type of variable, causing the > upper-half of the strucutre to be left uninitialized and causing: > > ethernet/qlogic/qed/qed_init_fw_funcs.c: In function > 'qed_set_rfs_mode_disable': > ethernet/qlogic/qed/qed_init_fw_funcs.c:993:3: error: '*((void > *)&ramline+4)' is used uninitialized in this function [-Werror=uninitialized] > > Fixes: d51e4af5c209 ("qed: aRFS infrastructure support") > Reported-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com>
> I don't see the original warning you've reported [probably due to > compiler differences], so other than via code reading I couldn't > actually test this. Can you please compile-test this one? I don't see the warning any more either with the compiler and defconfig I used last time, maybe some compiler flags have changed in the meantime. Anyway, your patch is definitely required to make it work correctly, so Reviewed-by: Arnd Bergmann <a...@arndb.de> Arnd